chore: bump pandas to latest stable version #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/bump-pandas-1.1
branch
from
096d110
to
af2010f
Compare
villebro
changed the title
dpgaspar
approved these changes
Sep 24, 2020
| @@ -16,3 +16,5 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| -e file:. | |||
| pyrsistent>=0.16.1,<0.17 | |||
There was a problem hiding this comment.
This is getting ugly, and will probably keep on getting uglier
villebro
commented
Sep 24, 2020
| ] | ||
| if level >= len(levels): | ||
| return [] | ||
| dim_level = levels[level][metric][[dims[0]]] |
There was a problem hiding this comment.
This logic has changed as of pandas>=1.1: previously additional keys in a nested MultiIndex were ignored, now they cause a KeyError. The correct behavior for this in this context is to just use the first index. So where we were previously able to do levels[level][metric][dims], now we must do levels[level][metric][[dims[0]]].
There was a problem hiding this comment.
Note to self (in case this causes a regression): levels[level][metric][[dims[-1]]] should produce the same result.
villebro
force-pushed
the
villebro/bump-pandas-1.1
branch
from
af2010f
to
513c663
Compare
rorymillersoft
referenced
this pull request
in nets-aric/incubator-superset
Oct 16, 2020
* master: (466 commits) chore: bump pandas to latest stable version (#11018) fix: dashboard edit button (again) (#11029) style(explore): use tertiary button against gray background (#11011) docs: add security vulnerability GH issue template (#11023) fix: [dashboard] should not show edit button when user has no edit permit (#11024) fix: timer component, fixes #10849, closes #11002 (#11004) fix: enable several pylint rules partially in db_engines_specs module (#11000) fix: pylint checks in connectors/sqla/models.py (#10974) fix: reenable pylint rule `unused-import` in charts and connectors modules (#11014) Enabled pylint rules in `db_engines` module: (#11016) fix: changes a pylint check in dashboard module (#10978) fix: menu shows a 0 when there are not settings (#11009) fix: query search low privileged user search access denied (#11017) chore: downgrade expected exception from error to info (#10994) fix: Add Item Overflow on Dataset Editor (#10983) Bring back import menu (#11007) feat(listview): feature flag config to set default viewing mode (#10986) build: add react-hooks linting (#11006) fix: unbreak ci (#11003) fix: enable pylint rules in db_engine_specs module (#10998) ... # Conflicts: # requirements.txt # superset/app.py # superset/models/schedules.py # superset/tasks/schedules.py # superset/translations/messages.pot
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* chore: bump pandas to latest stable version * fix nest_values
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current stable version of Pandas (1.1.2) has a fix for a critical bug affecting chart data API post processing aggregation operations (pandas-dev/pandas#30858). Also bump dependencies as consequence of recompiling
requirementsfiles.TEST PLAN
CI
ADDITIONAL INFORMATION